Disable drawing bold text bright by default

Since the assumption is usually that bold text is drawn in bright
colors, this might break some applications. However some other terminals
have already taken this leap, which should lessen the impact for
Alacritty.

Since this might still be desired and necessary for certain
applications, the config option is just switched to draw with normal
colors by default, however the old behavior can still be restored.

Fixes #2779.

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Renamed `WINIT_HIDPI_FACTOR` environment variable to `WINIT_X11_SCALE_FACTOR`
 - Print an error instead of crashing, when startup working directory is invalid
 - Line selection will now expand across wrapped lines
+- The default value for `draw_bold_text_with_bright_colors` is now `false`
 
 ### Fixed
 

alacritty.yml

@@ -177,7 +177,7 @@
   #use_thin_strokes: true
 
 # If `true`, bold text is drawn using the bright color variants.
-#draw_bold_text_with_bright_colors: true
+#draw_bold_text_with_bright_colors: false
 
 # Colors (Tomorrow Night Bright)
 #colors:

alacritty_terminal/src/config/mod.rs

@@ -60,7 +60,7 @@ pub struct Config<T> {
 
     /// Should draw bold text with brighter colors instead of bold font
     #[serde(default, deserialize_with = "failure_default")]
-    draw_bold_text_with_bright_colors: DefaultTrueBool,
+    draw_bold_text_with_bright_colors: bool,
 
     #[serde(default, deserialize_with = "failure_default")]
     pub colors: Colors,
@@ -149,7 +149,7 @@ impl<T> Config<T> {
 
     #[inline]
     pub fn draw_bold_text_with_bright_colors(&self) -> bool {
-        self.draw_bold_text_with_bright_colors.0
+        self.draw_bold_text_with_bright_colors
     }
 
     /// Should show render timer